Re: [PATCH] pci bridge class code

From: Greg KH (greg@kroah.com)
Date: Fri May 30 2003 - 18:15:02 EST


On Thu, May 29, 2003 at 01:17:42PM -0700, Mark Haverkamp wrote:
> This adds pci-pci bridge driver model class code. Entries appear in
> /sys/class/pci_bridge.

Nice, but I don't see the need for the extra class information, as it
doesn't really give us anything new, right? So without the class stuff
might be nice.

> +MODULE_AUTHOR("Mark Haverkamp");
> +MODULE_DESCRIPTION("PCI bridge driver");
> +MODULE_LICENSE("GPL");

This isn't needed, as you can't build your code as a module with your
patch.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/