__check_region in ide code?

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Fri Jun 06 2003 - 02:34:24 EST


Hi Bart,

        I notice that drivers/ide/ide-probe.c's hwif_check_region()
still uses check_region(). If it really does want to use it to probe
and not reserve, I think we should stop it warning there.

        There's nothing inherently *wrong* with check_region, it's
just deprecated to trap the old (now racy) idiom of "if
(check_region(xx)) reserve_region(xx)". There's no reason not to
introduce a probe_region if IDE really wants it.

Of course, some people will start "fixing" drivers by
s/check_region/probe_region/ when we do this, but that's the risk we
take.

It should also allow us to easily get rid of that stupid warning in
ksyms.c...

Thoughts?
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:29 EST