Re: Looks like your PCI patch broke the PPC build (and others)?

From: Benjamin Herrenschmidt (benh@kernel.crashing.org)
Date: Thu Jun 12 2003 - 08:35:25 EST


On Thu, 2003-06-12 at 09:10, Paul Mackerras wrote:
> Greg KH writes:
>
> > Not my patch, Matthew's :)
> >
> > I think the PPC developers have a fix for this.
>
> Just #include <asm/pci-bridge.h> at the top of include/asm-ppc/pci.h.
> I'll push that change to Linus.

Well... asm/pci-bridge.h includes linux/pci.h which includes asm/pci.h,
so we have a circular include here...

What I did in my tree is to move the definition of pci_controller
from asm/pci-bridge.h to asm/pci.h. I'm now considering removing
asm/pci-bridge.h, what do you think ?

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:32 EST