Re: [PATCH] udev enhancements to use kernel event queue

From: Oliver Neukum (oliver@neukum.org)
Date: Fri Jun 13 2003 - 15:01:47 EST


> +
> + spin_lock(&sequence_lock);
> + envp [i++] = scratch;
> + scratch += sprintf(scratch, "SEQNUM=%ld", sequence_num) + 1;
> + ++sequence_num;
> + spin_unlock(&sequence_lock);
>
> kobj_path_length = get_kobj_path_length (kset, kobj);
> kobj_path = kmalloc (kobj_path_length, GFP_KERNEL);

If this kmalloc fails, you'll have a hole in the numbers and
user space will be very confused. You need to report dropped
events if you do this.

        Regards
                Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:38 EST