Re: [PATCH] remove superfluous inode superblock check from shmem_mmap

• Next message: Christoph Hellwig: "Re: [PATCH] make cramfs look less hostile"
• Previous message: Jeremy Fitzhardinge: "Re: Flaw in the driver-model implementation of attributes"
• In reply to: James Morris: "[PATCH] remove superfluous inode superblock check from shmem_mmap"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, 16 Jun 2003, James Morris wrote:
> This patch against current 2.5 bk removes a (now) unecessary check for an
> inode superblock in shmem_mmap(). In the current kernel, all inodes must
> be associated with a superblock.

Thanks, looks good to me. I don't believe an inode with NULL i_sb
could ever have got to shmem_mmap - it's just a check copied over
from an old generic_file_mmap.

Andrew, please apply: thank you.
Hugh

diff -purN -X dontdiff bk.pending/mm/shmem.c bk.w1/mm/shmem.c
--- bk.pending/mm/shmem.c 2003-06-16 00:56:13.000000000 +1000
+++ bk.w1/mm/shmem.c 2003-06-16 02:06:55.142303751 +1000
@@ -1010,7 +1010,7 @@ static int shmem_mmap(struct file *file,
         struct inode *inode = file->f_dentry->d_inode;
 
         ops = &shmem_vm_ops;
- if (!inode->i_sb || !S_ISREG(inode->i_mode))
+ if (!S_ISREG(inode->i_mode))
                 return -EACCES;
         update_atime(inode);
         vma->vm_ops = ops;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Christoph Hellwig: "Re: [PATCH] make cramfs look less hostile"
• Previous message: Jeremy Fitzhardinge: "Re: Flaw in the driver-model implementation of attributes"
• In reply to: James Morris: "[PATCH] remove superfluous inode superblock check from shmem_mmap"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:42 EST