Re: [PATCH] make cramfs look less hostile

• Next message: Roman Zippel: "Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters"
• Previous message: Hugh Dickins: "Re: [PATCH] remove superfluous inode superblock check from shmem_mmap"
• In reply to: Jörn Engel: "Re: [PATCH] make cramfs look less hostile"
• Next in thread: Jörn Engel: "Re: [PATCH] make cramfs look less hostile"
• Reply: Jörn Engel: "Re: [PATCH] make cramfs look less hostile"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Jun 15, 2003 at 07:39:26PM +0200, Jörn Engel wrote:
> > Umm, cramfs_fill_super has a silent parameter that's true for
> > probing the root filesystem. I'd suggest disabling the printk
> > completly if it's set.
>
> Good idea, but only at first glance. cramfs_fill_super() always gets
> called with silent=1. So if "(!silent) printk(...);" is functionally
> equivalent to ";".

It's not. The rootfs is mounted with the (grossly misnamed) MS_VERBOSE
flag which translates to the last argument of the fill_super callback
set to 1.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Roman Zippel: "Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters"
• Previous message: Hugh Dickins: "Re: [PATCH] remove superfluous inode superblock check from shmem_mmap"
• In reply to: Jörn Engel: "Re: [PATCH] make cramfs look less hostile"
• Next in thread: Jörn Engel: "Re: [PATCH] make cramfs look less hostile"
• Reply: Jörn Engel: "Re: [PATCH] make cramfs look less hostile"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:42 EST