>>>>> On Wed, 18 Jun 2003 00:42:33 +0200, Vojtech Pavlik <vojtech@suse.cz> said:
>> so if a legacy speaker is present, it assumes a particular
>> frequency. In other words: it's a driver issue. On ia64, this
>> frequency certainly has nothing to do with time-keeping and
>> therefore doesn't belong in timex.h.
Vojtech> I'm quite fine with that. However, different (sub)archs,
Vojtech> for example the AMD Elan CPUs have a slightly different
Vojtech> base frequency. So it looks like an arch-dependent #define
Vojtech> is needed. I don't care about the location (timex.h indeed
Vojtech> seems inappropriate, maybe the right location is pcspkr.c
Vojtech> ...), or the name, but something needs to be done so that
Vojtech> the beeps have the same sound the same on all archs.
Sounds much better to me. Wouldn't something along the lines of this
make the most sense:
#ifdef __ARCH_PIT_FREQ
# define PIT_FREQ __ARCH_PIT_FREQ
#else
# define PIT_FREQ 1193182
#endif
After all, it seems like the vast majority of legacy-compatible
hardware _do_ use the standard frequency.
--david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:22 EST