Re: [RFC] PCI device list locking - take 3

From: Chris Wright (chris@wirex.com)
Date: Thu Jun 19 2003 - 13:49:01 EST

Next message: Thiago Rondon: "Re: [2.5 patch] 2.5.72: moxa.c doesn't compile"
Previous message: Andreas Boman: "Re: [PATCH] sleep_decay for interactivity 2.5.72 - testers needed"
In reply to: Greg KH: "[RFC] PCI device list locking - take 3"
Next in thread: Greg KH: "Re: [RFC] PCI device list locking - take 3"
Reply: Greg KH: "Re: [RFC] PCI device list locking - take 3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

* Greg KH (greg@kroah.com) wrote:
> Here's the latest version of the pci list locking patch. I've taken
> Chris's comments and addressed them by making sure we don't walk off the
> end of a deleted device in the pci_find_* and pci_get_* functions.

Looks good. Perhaps the pci_proc_detach should be earlier (i.e. before
list removal) to reflect the order in which things are added. I'm not
sure of the dependencies, but seems a good practice anyway.

thanks,
-chris

-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Thiago Rondon: "Re: [2.5 patch] 2.5.72: moxa.c doesn't compile"
Previous message: Andreas Boman: "Re: [PATCH] sleep_decay for interactivity 2.5.72 - testers needed"
In reply to: Greg KH: "[RFC] PCI device list locking - take 3"
Next in thread: Greg KH: "Re: [RFC] PCI device list locking - take 3"
Reply: Greg KH: "Re: [RFC] PCI device list locking - take 3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:30 EST