Re: [PATCH] fix for kallsyms module symbol resolution problem

From: James Bottomley (James.Bottomley@steeleye.com)
Date: Mon Jun 30 2003 - 09:10:46 EST


On Mon, 2003-06-30 at 01:17, Rusty Russell wrote:
> Yeah, but I was trying to get you to do more work. And if the names
> resulting are useless anyway, why apply the patch?

I noticed.

However, not printing empty names makes the trace a lot more useful.
Just doing a symbolic trace on modules on x86, I see pretty much the
correct call trace now.

But, I'll investigate and see if I can find a way of generically telling
if a particular symbol is useful or not.

> > Perhaps there should be a per-arch hook for purging the symbol tables of
> > irrelevant symbols before we do kallsyms lookups in it?
>
> I think you can do it easily in module_finalize... or if we were
> ambitious we'd extract only the function symbols rather than keeping
> the whole strtab and symtab.

Apart from the dubious writing to a const * pointer, yes I can (it's
what I'm doing now). There is some annoyance in that module_finalize
isn't told where the string or symbol tables are, so I have to find them
again.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 30 2003 - 22:00:33 EST