Re: [PATCH] cryptoloop

From: Andrew Morton (akpm@digeo.com)
Date: Wed Jul 02 2003 - 12:16:19 EST


Andries.Brouwer@cwi.nl wrote:
>
> +static int
> +cryptoloop_transfer(struct loop_device *lo, int cmd, char *raw_buf,
> + char *loop_buf, int size, sector_t IV)

You'll note that loop.c goes from (page/offset/len) to (addr/len), and this
transfer function then immediately goes from (addr,len) to
(page/offset/len).

That's rather silly, and it forces the loop driver to play games pushing
pages into lowmem.

Can we keep everything using (page/offset/len) end-to-end?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 07 2003 - 22:00:16 EST