On Fri, Jul 11 2003, Bartlomiej Zolnierkiewicz wrote:
>
> On Fri, 11 Jul 2003, Jens Axboe wrote:
>
> > On Fri, Jul 11 2003, Jens Axboe wrote:
> > > On Fri, Jul 11 2003, Jens Axboe wrote:
> > > > On Thu, Jul 10 2003, Ivan Gyurdiev wrote:
> > > > > See,
> > > > >
> > > > > http://www.ussg.iu.edu/hypermail/linux/kernel/0307.0/0515.html
> > > > >
> > > > > where the bug is described for 2.5.74.
> > > > > I got no replies, and the bug persists in 2.5.75 (+bk patches).
> > > > >
> > > > > Note:
> > > > > The machine boots with TASKFILE on, TCQ is causing the problem.
> > > >
> > > > Looks like IDE using the queue before it has been setup, probably Bart
> > > > broke it when he moved the TCQ init around. I'll take a look.
> > >
> > > Here's the fix. Bart, you moved the tcq init to a much earlier fase
> > > (saying ide_init_drive() was too early, well ide_dma_on is much earlier
> > > in the init fase). ide_init_drive() _is_ the correct location in my
> > > oppinion, drive and queue has been set up at this point.
>
> Yes, but hey you've acked this change ;-).
I know, I'll carry (let me see) 30% of the blame :)
> > Better still (and later in the probe) is this version. This is in my
> > oppinion the correct place to init tcq, and also contains it to ide-disk
> > where it should be.
>
> Looks okay, thanks.
Thanks, I'll forward it then.
-- Jens Axboe- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 15 2003 - 22:00:39 EST