Re: Fix IDE initialization when we don't probe for interrupts.

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Thu Jul 17 2003 - 10:32:38 EST

On 10 Jul 2003, Alan Cox wrote:
> On Mer, 2003-07-09 at 23:08, Jeff Garzik wrote:
> > > + * Disable device irq if we don't need to
> > > + * probe for it. Otherwise we'll get spurious
> > > + * interrupts during the identify-phase that
> > > + * the irq handler isn't expecting.
> > > + */
> > > + hwif->OUTB(drive->ctl|2, IDE_CONTROL_REG);
> >
> >
> > Yeah, my driver does probing with interrupts disabled, too.
> > I'm curious where interrupts are re-enabled, though?
>
> In the command write. BTW note that there are a few devices
> out there that dont honour the nIEN stuff.

Indeed. E.g. some old Western Digital Caviars.

I remember these giving me a bad time on Amiga. Apparently the problem didn't
show up on PC, since (in those days) IDE didn't share its interrupt with some
other device, unlike on Amiga.

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:29 EST