Re: SET_MODULE_OWNER

From: Jeff Garzik (jgarzik@pobox.com)
Date: Thu Jul 17 2003 - 11:00:58 EST


Thomas Schlichter wrote:
> On Thursday 17 July 2003 17:32, Jeff Garzik wrote:
>
>>Ricardo Bugalho wrote:
>>
>>>Hi all,
>>> most net device drivers have replaced MOD_INC/DEC_USE_COUNT with
>>>SET_MODULE_OWNER but SET_MODULE_OWNER doesn't do nothing.
>>> Therefore, those modules (though I can only vouch for 8139too) always
>>>report 0 use. Some people that had "modprobe -r" in their cronttab found
>>>it quite annoying.
>>> I'd guess that there's a good reason for why struct net_device doesn't
>>>have .owner field and why this happens. Can someone be so kind to point
>>>it
>>>out?
>>
>>struct net_device does have an owner field, and SET_MODULE_OWNER
>>obviously _does_ do something.
>
>
> That's not correct for 2.5.x anymore...
> Have a look at Changeset 1.1167 from davem.
>
> It removed the owner field about 9 weeks ago. That was the time where
> SET_MODULE_OWNER became a NOP...
>
>
>>If your interface is up, your net driver's module refcount is greater
>>than zero.
>
>
> Well, as I looked now my netdevice is up, but its reference count is at 0,
> too!

Doh. I missed that.

David? Does Rusty have a plan here or something?

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:29 EST