Marcelo,
David Hinds approves of this patch (Thanks, Dave!). Please apply to 2.4.22
Thanks!
- Bhavesh
-- Bhavesh P. Davda E-mail : bhavesh@avaya.com Avaya Inc. Phone/Fax : (303) 538-4438 Room B3-B03, 1300 West 120th Avenue Westminster, CO 80234-------David Hind's reply------------ From: David Hinds [dhinds@sonic.net] Sent: Saturday, July 19, 2003 3:32 PM To: Bhavesh P. Davda Subject: Re: [PATCH] AHA152x driver hangs on PCMCIA card eject, kernel2.4.22-pre6
On Thu, Jul 17, 2003 at 02:29:05PM -0600, Bhavesh P. Davda wrote: > > Attached is a patch that takes into account comments I have received in > response to the original patch I posted. Please peruse it, and if it looks > okay, please recommend that Marcelo pick it up for 2.4.22.
It looks ok to me. You can go ahead and send to Marcelo.
-- Dave -------------------------------------
> -----Original Message----- > From: Bhavesh P. Davda > Sent: Thursday, July 17, 2003 2:29 PM > To: David Hinds > Cc: Alan Cox; Linux Kernel Mailing List; fischer@norbit.de; > dahinds@users.sourceforge.net; Marcelo Tosatti > Subject: RE: [PATCH] AHA152x driver hangs on PCMCIA card eject, > kernel2.4.22-pre6 > > > > -----Original Message----- > > From: David Hinds [mailto:dhinds@sonic.net] > > Sent: Thursday, July 17, 2003 11:56 AM > > To: Bhavesh P. Davda > > Cc: Alan Cox; Linux Kernel Mailing List; fischer@norbit.de; > > dahinds@users.sourceforge.net; Marcelo Tosatti > > Subject: Re: [PATCH] AHA152x driver hangs on PCMCIA card eject, > > kernel2.4.22-pre6 > > > > > > On Thu, Jul 17, 2003 at 08:15:39AM -0600, Bhavesh P. Davda wrote: > > > > > > Right - scsi_unregister should not be called on a timer > event, instead > > > > it needs to kick off a task queue > > > > The removal timers need to be taken out from most *_cs drivers; they > > are a holdover from when card removal events were delivered in > > interrupt context, and when that was changed to an event handler > > thread, drivers were not changed accordingly. The removal routine > > should now just be called in-line instead of firing up a timer. > > > > > 2. What happens if there is no physical device hanging off an I/O port > > > address? I am guessing, that on an i386 host, the inb returns > > 0xFF, but am > > > not sure what happens on other architectures. I have a question > > outstanding > > > to Intel for this. > > > > On most but not all x86 systems floating ports return 0xff. Checking > > for that or other "impossible" register values should be at least > > harmless on other architectures. > > > > -- Dave > > Thank you, Dave! > > Attached is a patch that takes into account comments I have > received in response to the original patch I posted. Please > peruse it, and if it looks okay, please recommend that Marcelo > pick it up for 2.4.22. > > FYI, I have tested this patch on a PIII/440BX with a TI1225 based > PCMCIA card reader and Adaptec SlimSCSI 1460D SCSI adapter card > connected to a Fujitsu SCSI MO drive. > > Thanks! > > - Bhavesh > -- > Bhavesh P. Davda E-mail : bhavesh@avaya.com > Avaya Inc. Phone/Fax : (303) 538-4438 > Room B3-B03, 1300 West 120th Avenue > Westminster, CO 80234 >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:43 EST