Re: OOPS 2.6.0-test2, modprobe i810fb

From: Michael Driscoll (fenris@ulfheim.net)
Date: Wed Jul 30 2003 - 15:56:04 EST

Next message: Bagalkote, Sreenivas: "[ANNOUNCE] megaraid 2.00.6 driver"
Previous message: Greg KH: "Re: Support sharp zaurus C-750"
In reply to: Bill Davidsen: "Re: OOPS 2.6.0-test2, modprobe i810fb"
Next in thread: Andrew Morton: "Re: OOPS 2.6.0-test2, modprobe i810fb"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tuesday 29 July 2003 20:56, Bill Davidsen wrote:
> > diff -puN drivers/char/agp/intel-agp.c~intel-agp-oops-fix
> > drivers/char/agp/intel-agp.c ---
> > 25/drivers/char/agp/intel-agp.c~intel-agp-oops-fix 2003-07-28
> > 22:30:30.000000000 -0700 +++
> > 25-akpm/drivers/char/agp/intel-agp.c 2003-07-28 22:30:53.000000000 -0700
> > @@ -1426,7 +1426,7 @@ static struct pci_device_id agp_intel_pc
> > .subvendor = PCI_ANY_ID,
> > .subdevice = PCI_ANY_ID,
> > },
> > - { }
> > + { 0, },
> > };
> >
> > MODULE_DEVICE_TABLE(pci, agp_intel_pci_table);
> >
> > _
>
> Sure about that last comma? Any compiler version issues?

It's allowed in K&R2 (and explicitly marked as a feature, see pp.218-219).

I don't have C99 handy but I'm pretty sure it's still legal.

-- 
Michael Driscoll, fenris@ulfheim.net
"A noble spirit embiggens the smallest man" -- J. Springfield
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Bagalkote, Sreenivas: "[ANNOUNCE] megaraid 2.00.6 driver"
Previous message: Greg KH: "Re: Support sharp zaurus C-750"
In reply to: Bill Davidsen: "Re: OOPS 2.6.0-test2, modprobe i810fb"
Next in thread: Andrew Morton: "Re: OOPS 2.6.0-test2, modprobe i810fb"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:47 EST