Re: [PATCH] [1/2] random: SMP locking

From: Zwane Mwaikambo (zwane@arm.linux.org.uk)
Date: Sat Aug 02 2003 - 10:02:53 EST

Next message: Dave Jones: "Re: 2.6.0-test2-mm2"
Previous message: Jeff Garzik: "[bk patches] 2.4.x RNG doc patches"
In reply to: Matt Mackall: "Re: [PATCH] [1/2] random: SMP locking"
Next in thread: Andrew Morton: "Re: [PATCH] [1/2] random: SMP locking"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, 2 Aug 2003, Matt Mackall wrote:

> On Sat, Aug 02, 2003 at 08:35:22AM -0400, Zwane Mwaikambo wrote:
> > On Sat, 2 Aug 2003, Andrew Morton wrote:
> > > Cannot perform userspace access while holding a lock - a pagefault could
> > > occur, perform IO, schedule away and the same CPU tries to take the same
> > > lock via a different process.
> >
> > Perhaps might_sleep() in *_user, copy_* etc is in order?
>
> Wouldn't have caught this case - this interface hasn't actually been
> used/useful for many years as it only gives access to one of the
> pools and has never been atomic either.

Aha, thanks for the explanation.

Zwane

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Dave Jones: "Re: 2.6.0-test2-mm2"
Previous message: Jeff Garzik: "[bk patches] 2.4.x RNG doc patches"
In reply to: Matt Mackall: "Re: [PATCH] [1/2] random: SMP locking"
Next in thread: Andrew Morton: "Re: [PATCH] [1/2] random: SMP locking"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:19 EST