Re: [PATCH] 2.4.22pre10+aa: XFS has it right, setxattr() takes "const void *"

• Next message: Christoph Hellwig: "Re: [PATCH] 2.4.22pre10: fs/aio.c should include <linux/poll.h>"
• Previous message: Andrew Morton: "Re: [PATCH] make lookup_create non-static"
• In reply to: Chip Salzenberg: "[PATCH] 2.4.22pre10+aa: XFS has it right, setxattr() takes "const void *""
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Aug 04, 2003 at 01:02:16PM -0400, Chip Salzenberg wrote:
> It seems that the XFS developers have the right idea about setxattr(),
> namely that it should take a "const void *" parameter for the attributes
> it will set, rather than "void *".
>
> This patch Makes It So. It is in some sense only cosmetic, since the
> generated code is the same, but the usage of const is a Good Thing for
> this kind of interface.

Well, the const is how it works on 2.5, 2.4 should not change module
APIs. Please submit a patch for XFS instead to remove the const for
2.4.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Christoph Hellwig: "Re: [PATCH] 2.4.22pre10: fs/aio.c should include <linux/poll.h>"
• Previous message: Andrew Morton: "Re: [PATCH] make lookup_create non-static"
• In reply to: Chip Salzenberg: "[PATCH] 2.4.22pre10+aa: XFS has it right, setxattr() takes "const void *""
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:25 EST