[NFS] [PATCH] kNFSd: Fixes a problem with inode clean up for vxfs

From: Steve Dickson (SteveD@redhat.com)
Date: Wed Aug 06 2003 - 11:11:16 EST


This a patch I've received from Veritas. Supposedly they have
already submitted this but I can't seem to find it in any 2.4 trees..

Does anybody recognize this and are there any known issues with it?

The Problem: The nfsd_findparent creates a dentry using d_alloc_root.
The d_op
vector pointer in this dentry is not initialized. Hence filesystems that
supply
the vector have a problem. nfs exports of such filesystems do not work
correctly under memory pressure. vxfs, vfat, ntfs are amongst the
filesystems
affected by the bug. Need redhat to fix nfsd code in their kernels.
Ideally
a kernel needs to ask a filesystem to setup a d_op vector. An entry point
into a filesystem for doing this job doesn't exist. We can work around the
problem by copying d_op vector pointer from the child of the dentry, whose
d_op vector is correct.

The Patch:

--- ./fs/nfsd/nfsfh.c.diff Wed Jul 2 13:17:35 2003
+++ ./fs/nfsd/nfsfh.c Tue Jul 29 04:45:43 2003
@@ -303,6 +303,7 @@ struct dentry *nfsd_findparent(struct de
                       if (pdentry) {
                               igrab(tdentry->d_inode);
                               pdentry->d_flags |=
DCACHE_NFSD_DISCONNECTED;
+ pdentry->d_op = child->d_op;
                       }
               }
               if (pdentry == NULL)

SteveD.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:33 EST