Re: 2.6.0-test2-mm5

From: Jens Axboe (axboe@suse.de)
Date: Thu Aug 07 2003 - 03:44:52 EST

Next message: Arjan van de Ven: "Re: NPTL v userland v LT (RH9+custom kernel problem)"
Previous message: Nick Piggin: "Re: 2.6.0-test2-mm5"
In reply to: Nick Piggin: "Re: 2.6.0-test2-mm5"
Next in thread: Christoph Hellwig: "Re: 2.6.0-test2-mm5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Aug 07 2003, Nick Piggin wrote:
> --- linux-2.6/drivers/block/as-iosched.c.orig 2003-08-07 18:33:06.000000000 +1000
> +++ linux-2.6/drivers/block/as-iosched.c 2003-08-07 18:36:03.000000000 +1000
> @@ -1198,8 +1198,10 @@ static int as_dispatch_request(struct as
> */
> goto dispatch_writes;
>
> - if (ad->batch_data_dir == REQ_ASYNC)
> + if (ad->batch_data_dir == REQ_ASYNC) {
> + WARN_ON(ad->new_batch || ad->changed_batch);

combining debug checks like this is generally a bad idea imho, since you
don't know which of them triggered...

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Arjan van de Ven: "Re: NPTL v userland v LT (RH9+custom kernel problem)"
Previous message: Nick Piggin: "Re: 2.6.0-test2-mm5"
In reply to: Nick Piggin: "Re: 2.6.0-test2-mm5"
Next in thread: Christoph Hellwig: "Re: 2.6.0-test2-mm5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:37 EST