Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
> On Thursday 07 August 2003 10:39 am, Andrew Morton wrote:
> > Badari Pulavarty <pbadari@us.ibm.com> wrote:
> > > We should do readahead of actual pages required by the current
> > > read would be correct solution. (like Suparna suggested).
> >
> > I repeat: what will be the effect of this if all those pages are already in
> > pagecache?
>
> Hmm !! Do you think just peeking at pagecache and bailing out if
> nothing needed to be done, is too expensive ? Anyway, slow read
> code has to do this later. Doing it in readahead one more time causes
> significant perf. hit ?
It has been observed, yes.
> And also, do you think this is the most common case ?
It is a very common case. It's one we need to care for. Especially when
lots of CPUs are hitting the same file.
There are things we can do to tweak it up, such as adding a max_index to
find_get_pages(), then do multipage lookups, etc. But not doing it at all
is always the fastest way.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:40 EST