Re: [PATCH] 2.6.0 NBD driver: remove send/recieve race for request

From: Andrew Morton
Date: Fri Aug 08 2003 - 01:47:34 EST


Lou Langholtz <ldl@xxxxxxxx> wrote:
>
> >+ spin_unlock(&lo->queue_lock);
> >+ printk(KERN_DEBUG "%s: request %p: still in use (%d), waiting...\n",
> >+ lo->disk->disk_name, req, req->ref_count);
> >+ schedule_timeout(HZ); /* wait a second */
> >
> Isn't there something more deterministic than just waiting a second and
> hoping things clear up that you can use here?

you'll be needing a set_current_state() before calling schedule_timeout()
anyway. It will fall straight through as it is now.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/