Re: [PATCH] 2.4: Restore current->files in flush_old_exec

[Andreas Gruenbacher]

On Sat, 9 Aug 2003, Herbert Xu wrote:

> Hi:
>
> The unshare_files patch to flush_old_exec() did not restore the original
> state when exec_mmap fails.  This patch fixes that.

Indeed. This is still needed.

> At this point, I believe the unshare_files stuff should be fine from
> a correctness point of view.  However, there is still a performance
> problem as every ELF exec call ends up dupliating the files structure
> as well as walking through all file locks.

Cheers,
Andreas.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/