Re: [PATCH] misc 3c505 bits

[Jeff Garzik]

On Mon, Aug 11, 2003 at 02:40:25PM +0100, davej@xxxxxxxxxx wrote:
> - Remove unneeded breaks
> - Fix double spin_unlock_irqrestore problem
> 
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/3c505.c linux-2.5/drivers/net/3c505.c
> --- bk-linus/drivers/net/3c505.c	2003-05-26 12:57:43.000000000 +0100
> +++ linux-2.5/drivers/net/3c505.c	2003-06-04 14:07:40.000000000 +0100
> @@ -449,18 +449,18 @@ static int send_pcb(struct net_device *d
>  		case ASF_PCB_ACK:
>  			adapter->send_pcb_semaphore = 0;
>  			return TRUE;
> -			break;
> +
>  		case ASF_PCB_NAK:
>  #ifdef ELP_DEBUG
>  			printk(KERN_DEBUG "%s: send_pcb got NAK\n", dev->name);
>  #endif
>  			goto abort;
> -			break;

Disagree:  borks message.  You receive an ACK, and print "got NAK".

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/