Re: [PATCH] Remove useless assertions from reiserfs

[Valdis . Kletnieks]

On Mon, 11 Aug 2003 13:45:30 EDT, Jeff Garzik said:
> Why are these useless?

> >  	if (len >= 12)
> >  	{          
> >      //assert(len < 16);
> >               if (len >= 16)
> >                    BUG();
> 
> Seems like a valid check to me...

Just before that, there's code:

     while(len >= 16)
        {
	...
                len -= 16;
            }

So if that ever exits with a len >=16, we have a SERIOUS problem with
either the compiler or the hardware - as such, that "if (..) BUG" is dead code.
Similarly for the other checks.

Attachment: pgp00003.pgp
Description: PGP signature