Re: [PATCH] 2.4.22pre10: {,un}likely_p() macros for pointers

[Andrew Morton]

Albert Cahalan <albert@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> -#define likely(x)	__builtin_expect((x),1)
> -#define unlikely(x)	__builtin_expect((x),0)
> +#define likely(x)	__builtin_expect(!!(x),1)
> +#define unlikely(x)	__builtin_expect(!!(x),0)

Odd.  I thought we fixed that ages ago.

Being a simple soul, I prefer __builtin_expect((x) != 0, 1).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/