Re: [Dri-devel] Re: [PATCH] CodingStyle fixes for drm_agpsupport

From: Peter \"Firefly\" Lund
Date: Tue Aug 12 2003 - 07:12:46 EST


On Mon, 11 Aug 2003, Philip Brown wrote:

> if (!pointer) {
> return (whatever);
> }
>
>
> because it's consistent, and guaranteed safe from stupid parsing errors
^^^^^^^^^^^^^^^^^^^^^

return is /still/ not a function - so don't put in visual stuff that hints
that it is.

I can read it and understand it just fine -- if I slow down and think.
Don't make me think unless I absolutely have to. It might distract me
from more important aspects of the code and it steals my time.

-Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/