Re: [PATCH][2.6.0-test3] Disable APIC on reboot.

[Mikael Pettersson]

Maciej W. Rozycki writes:
 > On Tue, 12 Aug 2003, Mikael Pettersson wrote:
 > 
 > > @@ -249,6 +250,14 @@
 > >  	 * other OSs see a clean IRQ state.
 > >  	 */
 > >  	smp_send_stop();
 > > +#elif CONFIG_X86_LOCAL_APIC
 > > +	if (cpu_has_apic) {
 > > +		local_irq_disable();
 > > +		disable_local_APIC();
 > > +		local_irq_enable();
 > > +	}
 > > +#endif
 > > +#ifdef CONFIG_X86_IO_APIC
 > >  	disable_IO_APIC();
 > >  #endif
 > 
 >  You obviously want to disable I/O APICs first.

This follows the same order that the SMP reboot code has been using
for ages. I did check disable_IO_APIC(), and it does not depend on
the BP's local APIC being enabled.

I don't think there is a bug, but if there is, it's in the original
code too (simply trace what an SMP kernel on UP_IOAPIC HW would do).

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/