Re: C99 Initialisers

[Krzysztof Halasa]

Greg KH <greg@xxxxxxxxx> writes:

> -	{ PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100,
> -	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5700) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5701) },

We might even consider

+	{ PCI_DEVICE(BROADCOM, TIGON3_5700) },
+	{ PCI_DEVICE(BROADCOM, TIGON3_5701) },

As probably using anything but PCI_DEVICE_ID_* and PCI_VENDOR_ID_*
would be a bug.

+#define PCI_DEVICE(vend,dev) \
+	.vendor = (PCI_VENDOR_ID_##vend), .device = (PCI_DEVICE_ID_##dev), \
+	.subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID

-- 
Krzysztof Halasa
Network Administrator
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/