Re: C99 Initialisers

[Krzysztof Halasa]

Greg KH <greg@xxxxxxxxx> writes:

> > +	{ PCI_DEVICE(BROADCOM, TIGON3_5700) },
> > +	{ PCI_DEVICE(BROADCOM, TIGON3_5701) },
> > 
> Someone else mentioned that to me, but that's just mean as this file
> shows that not all device ids are in the pci id table.

PCI_VENDOR_ID_xxx can be #defined in the driver as well, no problem here.
Grepping - yes, real problem.

Using one 32-bit value for two 16-bit vendor and device IDs may be
worth considering, too. Some potential problems, though, not 2.6 I think.
-- 
Krzysztof Halasa
Network Administrator
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/