Re: Bogus serial port ttyS02

From: Russell King
Date: Sat Aug 16 2003 - 15:06:35 EST


On Sat, Aug 16, 2003 at 05:23:20PM +0200, Geert Uytterhoeven wrote:
> This patch kills a warning if DEBUG_AUTOCONF is enabled:
>
> --- linux-ppc-2.6.0-test3/drivers/serial/8250.c Mon Aug 11 02:20:41 2003
> +++ linux-longtrail-2.6.0-test3/drivers/serial/8250.c Wed Aug 13 22:31:07 2003
> @@ -557,7 +557,7 @@
> if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
> return;
>
> - DEBUG_AUTOCONF("ttyS%d: autoconf (0x%04x, 0x%08lx): ",
> + DEBUG_AUTOCONF("ttyS%d: autoconf (0x%04x, %p): ",
> up->port.line, up->port.iobase, up->port.membase);
>
> /*
> This patch removes the ASYNC_SKIP_TEST flag on PPC:
>
> --- linux-ppc-2.6.0-test3/include/asm-ppc/pc_serial.h Mon Aug 11 02:21:00 2003
> +++ linux-longtrail-2.6.0-test3/include/asm-ppc/pc_serial.h Wed Aug 13 23:01:50 2003
> @@ -28,10 +28,10 @@
>
> /* Standard COM flags (except for COM4, because of the 8514 problem) */
> #ifdef CONFIG_SERIAL_DETECT_IRQ
> -#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ)
> +#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_AUTO_IRQ)
> #define STD_COM4_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_AUTO_IRQ)
> #else
> -#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST)
> +#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF)
> #define STD_COM4_FLAGS ASYNC_BOOT_AUTOCONF
> #endif
>
> OK to apply?

Both look fine to me.

--
Russell King (rmk@xxxxxxxxxxxxxxxx) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/