Re: [PATCH] EISA bus update

[Greg KH]

On Tue, Aug 19, 2003 at 08:16:12PM +0200, Marc Zyngier wrote:
> >>>>> "Greg" == Greg KH <greg@xxxxxxxxx> writes:
> 
> Greg,
> 
> Greg> Marc, why do you think that you do not need to do anything in
> Greg> this function?  Don't you need to handle the fact that your code
> Greg> could be removed before the release function is called?
> 
> Well, there is nothing to do in this function, because that's what the
> whole driver does: nothing. It just presents a range of IO ports to be
> probed to the main EISA code, and nothing else.

But it exports something in sysfs, right?  Any reason you just don't
dynamically create it?  It's real hard to get static allocation of
struct device correct.

> If the driver is removed from the kernel (which can't happen at the
> moment, since it is not modular), it doesn't matter... 

Will this code ever be able to be built as a module?  If so, this will
not be correct.

> Once it has registered as an EISA bus root, it doesn't get called
> anymore, the core code does it all by itself.

So the release function never gets called at all then?  Why would this
be needed at all?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/