Re: [parisc-linux] Re: Problems with kernel mmap (failing tst-mmap-eofsyncin glibc on parisc)

From: Hugh Dickins
Date: Fri Aug 22 2003 - 13:42:42 EST


On Fri, 22 Aug 2003, David S. Miller wrote:
>
> So the proposed patch looks bogus to me.

And to me. If VM_SHARED is set, then __vma_link_file puts the vma on
on i_mmap_shared. If VM_SHARED is not set, it puts the vma on i_mmap.
flush_dcache_page treats i_mmap_shared and i_mmap lists equally.

Might the problem be in parisc's __flush_dcache_page,
which only examines i_mmap_shared?

Though it's odd, I'm not keen on changing do_mmap_pgoff's usage of
VM_SHARED in a hurry: it's worked like that for years, and other
things (I forget) depend on it.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/