Re: [PM] Patrick: which part of "maintainer" and "peer review" needsexplaining to you?

[Timothy Miller]

Pavel Machek wrote:

>  static int __init resume_setup(char *str)
>  {
> -	strncpy( resume_file, str, 255 );
> +	if (strlen(str))
> +		strncpy(resume_file, str, 255);
>  	return 1;
>  }


Silly me, but if you want to check to be sure a string has a length 
greater than zero, wouldn't it be faster to just check to be sure that 
the first byte is not zero?

Think about how much work it does if the string is 100 characters long 
when all you want to do is determine that it's non-zero.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/