Re: Promise IDE patches

From: Jan Niehusmann
Date: Wed Aug 27 2003 - 10:13:33 EST


On Wed, Aug 27, 2003 at 03:59:52PM +0100, Alan Cox wrote:
> If you fail to do this then existing PIO LBA48 setups will just die
> on boot.

But 'die on boot' is much better than 'silently currupt data', don't you
think?
Still, a proper fix would work in all cases...

What do you think about a check in __ide_do_rw_disk? calling
lba_28_rw_disk or chs_rw_disk when the block address doesn't fit in
28bit is surely wrong and should return an error.

This will lead to read or write errors if LBA48 doesn't work, but
it will prevent silent data corruption.

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/