Re: [PATCH] Backport recent IDE updates, take 2

[Alan Cox]

On Mer, 2003-08-27 at 21:39, Erik Andersen wrote:
>                 if (drive->addressing == 0 && drive->capacity64 > (1ULL)<<28) {
>                         /* FIXME:  most controllers that won't do LBA48 with
>                          * DMA will do it via PIO so we ought to implement a
>                          * PIO fallback...   For now, punt and limit the drive
>                          * to 128 GiB to prevent bad things from happening... */
>                         drive->capacity64 = (1ULL)<<28;
>                 }
> 	}
> 
> This is not sufficient?

Its sufficient to stop bad things happening, its not sufficient to get
the desired end user result of being able to read their disk if it moved
controller. Bartlomiej pointed out that because of the other traps the
problem doesn't occur right now except moving a disk.

I'll post an additional diff tomorrow which adds hwif->dma_addressing
(or dma_lba48 given the changes to naming people seem to prefer) so that
can get fixed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/