Re: [2.4.22-rc1] ext3/jbd assertion failure transaction.c:1164

From: Stephen C. Tweedie
Date: Thu Aug 28 2003 - 16:20:25 EST


Hi,

On Thu, 2003-08-28 at 14:57, Pascal Schmidt wrote:

> > Many thanks --- I was able to reproduce this very easily, and I know of
> > one or two very unusual things that fsx does which might well be the
> > trigger here. I'll let you know how things go.
>
> Good, at least it's not a bug that only happens here and is hard to
> reproduce elsewhere.
>
> I hope this does not happen under normal fs usage. ;)

It's all down to ext3_writepage() using data-journaling rather than
metadata journaling.

The obvious fix is just to make the journal_dirty_async_data() code
commit its writes as metadata if the inode is marked for
data-journaling, and to set the transaction handle to be synchronous in
that case. Sounds like a recipe for deadlock if done incorrectly,
though, so I'll give it a more careful look tomorrow.

Cheers,
Stephen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/