Re: Fix up power managment in 2.6

[bill davidsen]

In article <20030903174904.GH30629@xxxxxxxxxxxxxxxxxxxxxxxx>,
Pavel Machek  <pavel@xxxxxxx> wrote:
| Hi!
| 
| > > -void software_resume(void)
| > > +int __init swsusp_restore(void)
| > >  {
| > > -       if (num_online_cpus() > 1) {
| > > -               printk(KERN_WARNING "Software Suspend has
| > > malfunctioning SMP support. Disabled :(\n");
| > > -               return;
| > > -       }
| > > 
| > > I can not easily see where you moved this check.
| > 
| > Read the rest of the patches, and the changelogs (I do believe it's in 
| > them). It's in kernel/power/main.c::enter_state(), so all PM handlers can 
| > use it. 
| 
| Notice that this is done during resume. You are free to suspend with 1
| cpu, then attempt to resume with 2 cpus. Not *too* likely to happen,
| but....

Would it matter if you did? Unless you are running an SMP kernel? I
guess at some point the laptop CPUs will have HT, and SMP will be more
of an issue than it is now.
-- 
bill davidsen <davidsen@xxxxxxx>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/