Re: Fix up power managment in 2.6

[Patrick Mochel]

> > > -void software_resume(void)
> > > +int __init swsusp_restore(void)
> > >  {
> > > -       if (num_online_cpus() > 1) {
> > > -               printk(KERN_WARNING "Software Suspend has
> > > malfunctioning SMP support. Disabled :(\n");
> > > -               return;
> > > -       }
> > > 
> > > I can not easily see where you moved this check.
> > 
> > Read the rest of the patches, and the changelogs (I do believe it's in 
> > them). It's in kernel/power/main.c::enter_state(), so all PM handlers can 
> > use it. 
> 
> Notice that this is done during resume. You are free to suspend with 1
> cpu, then attempt to resume with 2 cpus. Not *too* likely to happen,
> but....

That's a silly thing to do, though I don't support the notion of letting 
people find out the hard way. Why not just fail on CONFIG_SMP until it's 
done right? 



	Pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/