Re: [PATCH] use size_t for the broken ioctl numbers

[Linus Torvalds]

On Sun, 7 Sep 2003, Andreas Schwab wrote:
> 
> Here is a patch that enforces the use of types in the third argument.  It
> requires gcc >= 3.1 for the check to work, I couldn't find a method for
> previous versions.

Ehh, what's wrong with the obvious approach: declare a dummy variable. If 
it's not a type, then the declaration won't work.

Ie, change the (sizeof(x)) to something like

	({ x __dummy; sizeof(__dummy); })

which should work with all compiler versions.

Anything that requires a new compiler is always a big dodgy as a sanity 
check. People who don't have the new compiler won't be testing it, so 
they'll just continually break it for people who _do_. Aggravation 
nightmare.

		Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/