Re: [PATCH] fix Summit srat.h includes

[Martin J. Bligh]

> I was compiling for my plain 'ol PC, and was getting unresolved symbols
> for get_memcfg_from_srat() and get_zholes_size().  The CONFIG_NUMA
> definition right now allows it to be turned on for plain old X86_PC. 
> Does anyone know why this is?  

Yeah, distros want it, so they can ship one kernel for SMP that covers
NUMA and non-NUMA, switching dynamically.
 
> depends on SMP && HIGHMEM64G && 
>           (X86_PC || X86_NUMAQ || X86_GENERICARCH || 
>                   (X86_SUMMIT && ACPI && !ACPI_HT_ONLY))
> 
> In any case, the summit code incorrectly assumes in at least 2 places
> that NUMA && !NUMAQ means summit.  Someone was evidently trying to cover
> the generic subarch case, but that's already taken care of by the lovely
> config system and CONFIG_ACPI_SRAT.  This patch fixes those assumptions
> and adds a nice little warning for people that try to #include srat.h
> without having srat support turned on.  

Nice, thanks. Yeah, the generic NUMA on generic PC code will need a bit
of tidy up, but it should more or less work ;-)

Thanks,

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/