Re: [PATCH] More MODULE_ALIAS work, and documentation updates.

[Takashi Iwai]

Hi,

At Wed, 10 Sep 2003 17:52:11 +1000,
Rusty Russell wrote:
> 
> Hi all,
> 
> 	I know this is something of a megapatch, but I'm trying to get
> all the module aliases people expect into the modules before 2.6.0.  I
> got most of these by reading the documentation: review appreciated.
> 
> 	If noone NAKs, I'll send to Linus in a couple of days.  I'm
> sure you can think of other aliases which should be added, too.

the ALSA part looks fine for me.
and it looks now much much cleaner.  thanks!

well, very subtle things:
for sound-service-?-1 and sound-service-?-8, only 0 is available,
and other numbers don't exist.
so, the definition in sound/core/seq/oss/seq_oss.c can be like

MODULE_ALIAS("sound-service-0-" __stringify(SNDRV_MINOR_OSS_SEQUENCER));
MODULE_ALIAS("sound-service-0-" __stringify(SNDRV_MINOR_OSS_MUSIC));

but it's harmless to use MODULE_ALIAS_SNDRV_MINOR() as you did... :)


--
Takashi Iwai <tiwai@xxxxxxx>		SuSE Linux AG - www.suse.de
ALSA Developer				ALSA Project - www.alsa-project.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/