Re: Options for handling buggy PCI/PCI-X hardware when MSI is enabled

From: Andi Kleen
Date: Tue Sep 16 2003 - 18:46:52 EST


"Nakajima, Jun" <jun.nakajima@xxxxxxxxx> writes:

> "Blacklist" approach using PCI_quirks.c
> ---------------------------------------
> Pros
> - Places the burden to fix broken HW on the HW owners
> - Consistent with the current MSI patch (enable all by default)
> - A simple fix and minimum patch size (Patch already exists)
> Cons
> - Core kernel impact (larger image size)

And worse one has to submit patches for the core kernel all the time.
And it's a single table, which means there will be lots of conflicts
when merging patches.

I think the new API approach is much better. Best would be if there
was a relatively simple standard way to add it to drivers (like a
standard module option). Then one could add it to a lot of drivers
with default to off. Users can test then and if it works the default
can be changed.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/