RE: [PATCH] Net device error logging, revised

[Feldman, Scott]

> 3. A new macro, netdev_fatal, is included.  Given the call
>         netdev_fatal(dev, HW, "NIC fried!\n");
> the indicated message is always logged: the msglevel arg (HW, in this
> case) is NOT consulted.  In fact, the msglevel arg to netdev_fatal
> is ignored in this implementation.  (As previously discussed, in some
> future implementation, the msglevel could be logged to help indicate
> the circumstances under which the event was logged.)

I couldn't find the previous discussion on netdev_fatal, so sorry if
this has already been worked out.  It uses KERN_ERR; did you mean
something stronger?  If not, why not just use netdev_err(dev, ALL,
"...")?  What is the situation in the driver where we'd want to use
_fatal?  How do I know when to use _fatal and when to use _err?

-scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/