Re: What's the point of __KERNEL_SYSCALLS__?

From: viro
Date: Sun Sep 21 2003 - 00:24:43 EST


> --- drivers/media/dvb/frontends/alps_tdlb7.c 29 Jul 2003 17:25:42 -0000 1.2
> +++ drivers/media/dvb/frontends/alps_tdlb7.c 21 Sep 2003 04:01:52 -0000
[snip]
> @@ -161,25 +158,25 @@ static int sp8870_read_code(const char *
> loff_t l;
> char *dp;
>
> - fd = open(fn, 0, 0);
> + fd = sys_open(fn, 0, 0);

*Ugh*

What context is it executed in? I'd tried to trace the potential callers,
but I don't see immediate reasons to believe that it never can happen in
user task context. It either should be shown (and commented) or we'd
better switch to filp_open() and friends. Descriptor tables can be shared...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/