Re: log-buf-len dynamic

From: Andrea Arcangeli
Date: Tue Sep 23 2003 - 17:36:26 EST


On Tue, Sep 23, 2003 at 09:02:19PM +0200, Willy Tarreau wrote:
> > My API is good for everyone, yours is not
>
> I'm impressed that you know so many people. I know that mine at least
> satisfies a few collegues, customers, and I. So I deduced that it might be
> useful to others too. Even Marcelo thought the same a time ago.

I know your patch was just very good for many people, but not for
everyone. I really didn't want to say your patch didn't make any good,
I acknowledge it was just very good.

Here I need an argument from you that explains me why should I work
further on the current code to make the config option still usable. I
see no reason to spend time in that effort because the config option
will provide no benefit compared to the kernel parameter.

If you can explain me _why_ you don't want to pass the kernel parameter
than you will convince me, if it's just that "you don't want it" then I
can't buy that. Give me a valid argument and I will have a reason to
retain the config option.

I definitely agree my patch (btw, I posted the last one that had a few
bugs too) needs fixing to release the 64k of ram, and to allow a smaller
bufsize too (the latter will happen automatically while addressing the
former)

The fact you don't want to touch the lilo.conf doesn't sound to me.
Especially with lilo (not grub) you've to run lilo anyways every time
you replace the kernel, so a simple script adding the parameter in every
lilo.conf sounds very easy to provide (you can add it in all kernels,
the old ones will ignore it).

Andrea - If you prefer relying on open source software, check these links:
rsync.kernel.org::pub/scm/linux/kernel/bkcvs/linux-2.[45]/
http://www.cobite.com/cvsps/
svn://svn.kernel.org/linux-2.[46]/trunk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/