Re: [Bonding-announce] [PATCH SET][bonding] cleanup

From: Chad N. Tindel
Date: Thu Sep 25 2003 - 11:47:34 EST


> patch set can be downloaded from:
> http://osdn.dl.sourceforge.net/sourceforge/bonding/bonding-cleanup-2.4.23-pre5.tar.bz2
>
> This will update the following files:
>
> Documentation/networking/bonding.txt
> Documentation/networking/ifenslave.c
> drivers/net/bonding/bond_3ad.c
> drivers/net/bonding/bond_alb.c
> drivers/net/bonding/bond_alb.h
> drivers/net/bonding/bonding.h
> drivers/net/bonding/bond_main.c
> include/linux/if_bonding.h
>
> Description:
> patch 1 - ifenslave lite - No more IP settings to slaves, unified
> printing format, code re-org and broken to more functions.
> patch 2 - convert all debug prints to use the dprintk macro and
> consolidate format of all prints (e.g. "bonding: Error:
> ...").
> patch 3 - death of typedef. eliminate bonding_t/slave_t types and
> consolidate casting.
> patch 4 - remove dead code, old compatibility stuff and redundant
> checks.

I'm a bit concerned about doing some of this stuff in the 2.4 series. That
compatibility stuff is there for a reason, and was set to be removed in
2.6. Perhaps we shouldn't be doing stuff this drastic until 2.6 because of
the risk of breaking users.

Chad
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html