Re: [PATCH 6/8] Extend KD?BENT to handle > 256 keycodes.

[Andries Brouwer]

On Thu, Sep 25, 2003 at 06:50:12PM +0200, Vojtech Pavlik wrote:

> -struct kbentry {
> +struct kbentry_old {
>  	unsigned char kb_table;
>  	unsigned char kb_index;
>  	unsigned short kb_value;
>  };
> +#define KDGKBENT_OLD	0x4B46	/* gets one entry in translation table (old) */
> +#define KDSKBENT_OLD	0x4B47	/* sets one entry in translation table (old) */
> +
> +struct kbentry {
> +	unsigned int kb_table;
> +	unsigned int kb_index;
> +	unsigned short kb_value;
> +};

> -#define KDGKBENT	0x4B46	/* gets one entry in translation table */
> -#define KDSKBENT	0x4B47	/* sets one entry in translation table */
> +#define KDGKBENT	0x4B73	/* gets one entry in translation table */
> +#define KDSKBENT	0x4B74	/* sets one entry in translation table */

Please don't.

As said already, no new ioctls are needed today, but if you add some
anyway, please leave old names unchanged and add something new, like
KDSKBENT32 or so.

Reusing old ioctl names for new uses is very bad practice.

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/