Re: 2.6.0-test6: a few __init bugs

[Pavel Machek]

Hi!

> Here are several places where non-__init functions call __init functions
> or reference __init data.  I've looked at all of them and believe that
> they are all either legitimate bugs or opportunities to declare more
> code as __init to save memory.  Thanks for looking over these, and sorry
> if I've made any mistakes.

> ** Code should be declared __init?
> ** name_to_dev_t()                                                     (__init)
>      called by kernel/power/swsusp.c:read_suspend_image()              (not __init)
>        called by kernel/power/swsusp.c:software_resume()               (not __init)
> Fix: declare read_suspend_image() __init
> Fix: declare software_resume() __init
> 
> Note: read_suspend_image() in pmdisk.c is declared __init.

Yes, it should be safe to declare that code __init. Applied.

								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/