include/linux/nfs/nfsfh.h declares a symbol

From: Jörn Engel
Date: Wed Oct 01 2003 - 07:20:00 EST


Neil, the function SVCFH_fmt uses a static variable to sprintf into.
Looks like this variable is declared locally for every .c file
including nfsfh.h, which is quite a few.

You could remove the static, but that would increase the stack usage,
which might be a problem too. The buffer could be reduced to 64
chars, to reduce that problem. kmalloc()ing it seems a bit expensive,
but might be an option, too.

Thanks!

Jörn

--
This above all: to thine own self be true.
-- Shakespeare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/