Re: [PATCH] Initializedd the module parameters indrivers/net/wireless/arlan-main.c

[Randy.Dunlap]

On Wed, 01 Oct 2003 19:01:04 +1000 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

| In message <200309291644.06043.shinemohamed_j@xxxxxxxxxxxxxx> you write:
| > Quick patch to  Initialize  the module parameters in 
| > drivers/net/wireless/arlan-main.c
| > @@ -33,6 +33,7 @@
| >  static int retries = 5;
| >  static int tx_queue_len = 1;
| >  static int arlan_EEPROM_bad;
| > +static int probe = 0; /* Initially it is setting to be 'Probing Disabled' */
| > 
| >  #ifdef ARLAN_DEBUGGING
| 
| This is clearly wrong: it's declared below.

Hello.  Anybody there?

This is what you get with 2.6.0-test6 plain vanilla:

[rddunlap@midway linux-260-test6-work]$ make modules
  SPLIT   include/linux/autoconf.h -> include/config/*
make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
  CC [M]  drivers/net/wireless/arlan-main.o
drivers/net/wireless/arlan-main.c: In function `init_module':
drivers/net/wireless/arlan-main.c:1923: `probe' undeclared (first use in this function)
drivers/net/wireless/arlan-main.c:1923: (Each undeclared identifier is reported only once
drivers/net/wireless/arlan-main.c:1923: for each function it appears in.)
make[3]: *** [drivers/net/wireless/arlan-main.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2


so is MODULE_PARM(probe, "i");
supposed to be declaring <probe>?  It's not.
If it is supposed to be, then why are most/many/all other MODULE_PARM's
in that file also declared separately (i.e., again)?


The only wrong part I see is that it doesn't need to be init to 0.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/